-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️🐛 #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mraniki - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -248,7 +248,8 @@ async def get_instrument_decimals(self, instrument): | |||
async def get_instrument_min_amount(self, instrument): | |||
""" """ | |||
instrument_info = self.client.single_market(instrument) | |||
minimum_amount = instrument_info.get("minDealSize", {}).get("value", 0) | |||
logger.debug("instrument_info {}", instrument_info) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Consider adding more descriptive logging for instrument_info
.
Including specific fields of interest in the log could help in debugging specific issues more effectively.
logger.debug("instrument_info {}", instrument_info) | |
logger.debug("instrument_info: dealingRules: {}", instrument_info.get("dealingRules")) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 71.46% 71.52% +0.06%
==========================================
Files 7 7
Lines 438 439 +1
==========================================
+ Hits 313 314 +1
Misses 125 125 ☔ View full report in Codecov by Sentry. |
No description provided.